Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update test file format to support aggregate functions #736

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Nov 8, 2024

No description provided.

grammar/FuncTestCaseParser.g4 Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: Eventually we want to stop checking these in if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the grammar changes are stable, the checkins to auto-generated files will stop (I think it will be sooner than later, we have to add existing BFT tests in new format here).
We have a pre-commit check on test coverage so we need this file in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the files are generated by the author then there's a chance that the grammar changed but the parser files did not. By running the generation as part of the coverage check we can ensure that the files are matching.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @EpsilonPrime . We can have the coverage test include:

  • generate the parser
  • run the tests
    So we should ultimately land with no need to check in generated files. (Their only purpose is to complete the tests.)

One other ticket we should think about: add CI checks that new functions have test coverage and test coverage shouldn't go down.

@scgkiran
Copy link
Contributor Author

scgkiran commented Nov 9, 2024

We can have the coverage test include:

  • generate the parser
  • run the tests
    So we should ultimately land with no need to check in generated files. (Their only purpose is to complete the tests.)

I will address this in another PR.

One other ticket we should think about: add CI checks that new functions have test coverage and test coverage shouldn't go down.

I have added a check here. This should catch if a new function is added without testcases. Once we have more tests checked in, we can improve the check to report functions with no coverage or less coverage.

@EpsilonPrime EpsilonPrime merged commit c18c0c1 into substrait-io:main Nov 9, 2024
13 checks passed
@scgkiran scgkiran deleted the agg_func_testcase_format branch December 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants