Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add substrait test files to go embedded fs #740

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

scgkiran
Copy link
Contributor

No description provided.

Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the purpose of this PR is to make the function compliance tests visible to the Go module for use by systems wanting to run the compliance checks elsewhere?

That's fine with me but I wonder if it should be a separate Go module so that folks only wanting the definitions can get to them separately. It would be additionally nice if we could keep the non-definition files out of the root directory for the repository.

@scgkiran
Copy link
Contributor Author

So the purpose of this PR is to make the function compliance tests visible to the Go module for use by systems wanting to run the compliance checks elsewhere?

Yes

That's fine with me but I wonder if it should be a separate Go module so that folks only wanting the definitions can get to them separately. It would be additionally nice if we could keep the non-definition files out of the root directory for the repository.

I felt its too small to make it a separate module. I moved tests to a new embedFS.

@EpsilonPrime EpsilonPrime merged commit e3a7773 into substrait-io:main Nov 14, 2024
13 checks passed
@scgkiran scgkiran deleted the go_embed branch December 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants