feat: add expression support for count and offset in the fetch operator #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
|
|
EpsilonPrime
previously approved these changes
Nov 25, 2024
jacques-n
reviewed
Nov 25, 2024
EpsilonPrime
previously approved these changes
Dec 4, 2024
westonpace
previously approved these changes
Dec 4, 2024
Co-authored-by: Weston Pace <[email protected]>
jcamachor
dismissed stale reviews from westonpace and EpsilonPrime
via
1b6fa78
|
@EpsilonPrime , @westonpace , could you please re-cast your approvals so we can merge? Thanks |
westonpace
approved these changes
Dec 9, 2024
EpsilonPrime
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done in a way that should be effectively compatible with old systems. Old plans should be able to continue to be consumed treating the old values as int64.
BREAKING CHANGE: The encoding of FetchRel has changed in a strictly backwards incompatible way. The change involves transitioning offset and count from a standalone int64 field to a oneof structure, where the original int64 field is marked as deprecated, and a new field of Expression type is introduced. Using a oneof may cause ambiguity between unset and set-to-zero states in older messages. However, the fields are defined such that their logical meaning remains indistinguishable, ensuring consistency across encodings.