feat: support missing variants for regexp string functions #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikrishnak
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
srikrishnak
changed the title
|
Once this PR is merged, we can switch bft to use the substrait test cases with PR substrait-io/bft#98 This PR will ensure tests for regexp_* functions for the dialects postgres, duckdb and datafusion keep passing on bft post switch. |
srikrishnak
changed the title
jacques-n
reviewed
Dec 2, 2024
EpsilonPrime
reviewed
Dec 2, 2024
EpsilonPrime
approved these changes
Dec 4, 2024
|
Hi @jacques-n , Can you please review this PR. It needs second approval. Thanks |
jacques-n
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.