Garmin: Add MTP Support for More Models.

[mikeller]

Add MTP support for more of the newer Garmin Descent models.

[Copilot]

Pull Request Overview

Add MTP support for additional Garmin Descent models by centralizing model metadata and leveraging a shared model list in both the parser and device code.

• Introduce a garmin_model_t struct (including an mtp_capable flag) and declare a global garmin_models array in the header.
• Update src/garmin_parser.c to use the shared garmin_models array instead of a local static list.
• Enhance MTP detection logic in src/garmin.c to iterate over garmin_models and skip non-MTP-capable devices.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/garmin_parser.c	Removed local models[] array, replaced with garmin_models lookup.
src/garmin.h	Added garmin_model_t definition (with mtp_capable) and extern array.
src/garmin.c	Defined garmin_models with MTP flags, updated product-ID checks.

Comments suppressed due to low confidence (2)

src/garmin_parser.c:1667

• [nitpick] The loop index variable 'i' is not descriptive. Consider renaming it to something like 'model_index' for clarity.

unsigned i;

src/garmin.h:39

• Consider adding a comment explaining what the 'mtp_capable' flag represents and how it should be used, to improve code self-documentation.

    bool mtp_capable;

[Copilot]

Magic number 0x4000 is used to derive the USB product ID flag. Consider defining a named constant (e.g., USB_MTP_FLAG) to improve readability and maintainability.

Suggested change

	if ((garmin_models[j].id | 0x4000) == rawdevices[i].device_entry.product_id) {
	if ((garmin_models[j].id | USB_MTP_FLAG) == rawdevices[i].device_entry.product_id) {