Skip to content

Commit

Permalink
vdso/bits.h: Add BIT_ULL() for the sake of consistency
Browse files Browse the repository at this point in the history
The minimization done in 3945ff3 ("linux/bits.h: Extract common header
for vDSO") was required to isolate the VDSO build from the larger kernel
header impact.

The split added some inconsistency since BIT() and BIT_ULL() are now
defined in the different files which confuses unprepared reader.

Move BIT_ULL() to vdso/bits.h. No functional change.

Signed-off-by: Andy Shevchenko <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
andy-shev authored and KAGA-KOKO committed Jan 31, 2023
1 parent 0c52310 commit cbdb1f1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion include/linux/bits.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include <vdso/bits.h>
#include <asm/bitsperlong.h>

#define BIT_ULL(nr) (ULL(1) << (nr))
#define BIT_MASK(nr) (UL(1) << ((nr) % BITS_PER_LONG))
#define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
#define BIT_ULL_MASK(nr) (ULL(1) << ((nr) % BITS_PER_LONG_LONG))
Expand Down
1 change: 1 addition & 0 deletions include/vdso/bits.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
#include <vdso/const.h>

#define BIT(nr) (UL(1) << (nr))
#define BIT_ULL(nr) (ULL(1) << (nr))

#endif /* __VDSO_BITS_H */

0 comments on commit cbdb1f1

Please sign in to comment.