-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fido PSP FIELDS radio data client #34
Conversation
Hello @samaloney! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-12 16:41:01 UTC |
If you have some time, if you could rebase this on top current master. |
961f860
to
0e30e6a
Compare
these are great @samaloney ! trying to bring back life to radio spectra! The only thing is that I don't think that these will work with the updated Fido generic client!(?) |
83780c1
to
40a0c97
Compare
I think at this stage all the failures are to be expected until new sunpy 2.1 is released and decpenecnes are bumped here. |
Maybe I'm going mad... I checked out this branch and then tried to do AttributeError: module 'sunpy.net.attrs' has no attribute 'Source' I'm on sunpy 2.0.3 What am I doing wrong? |
Source was moved there in sunpy master but not in 2.0, this PR only works on sunpy master. |
oh yeah - thanks! I should have read Shane's previous comment 🤦 thanks @nabobalis |
bba501f
to
8adac8a
Compare
d532195
to
660e0b6
Compare
* Add new generic client * Add tests * Add to API docs
Co-authored-by: Nabil Freij <[email protected]>
0b533d0
to
8b69a3f
Compare
You should adjust .gitattributes (see https://github.com/sunpy/sunpy/blob/master/.gitattributes) so that is a binary file: radiospectra/tests/data/BIR_20110607_062400_10.fit |
Co-authored-by: Nabil Freij <[email protected]>
It works 🚀
radiospectra.net.sources