[WIP] Add 485 deadtime enforcement #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://www.modbus.org/docs/Modbus_over_serial_line_V1_02.pdf 2.5.1.1 MODBUS Message RTU Framing In RTU mode, message frames are separated by a silent interval of at least 3.5 character times.
Especially in older versions, `time.sleep()` may return early. https://docs.python.org/3.7/library/time.html#time.sleep
|
For what it's worth, I'd call this a bug fix. It's been over a year but as I recall the existing code doesn't follow the Modbus standard to the point that it was actually causing problems. |
|
Closure was accidental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.modbus.org/docs/Modbus_over_serial_line_V1_02.pdf
2.5.1.1 MODBUS Message RTU Framing
In RTU mode, message frames are separated by a silent interval of at least 3.5 character times.
WIP for: