fix: positional params #473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
requested changes
Aug 14, 2025
| "; | ||
| test_db.execute(setup_sql).await.expect("setup sql failed"); | ||
|
|
||
| let content = r#"select * from users where id = @one and name = :two and email = :'three';"#; |
There was a problem hiding this comment.
:'three' – i want to meet the person who writes syntax like this haha
There was a problem hiding this comment.
haha yeah I did for some time two years ago :D
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_convert_to_positional_params() { | ||
| let input = "select * from users where id = @one and name = :two and email = :'three';"; |
There was a problem hiding this comment.
what about duplicate identifier names?:
select * from users
where first_name = @one
and starts_with(email, @one)
and created_at > @two;There was a problem hiding this comment.
good catch! fixed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-processes the query string to replace named params like
@namewith positional params like$1, because only the latter is supported by the postgres parser.not super happy with the way it is used for the type checker but also did not want to put that function in another crate.
also removed a
println!statement leftover from a previous pr of me.also fixed a bug in the lexer that tokenized a cast as a named parameter.
fixes #405, #454