feat: allow promises in CookieAuthStorageAdapter #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhpreet
added a commit
to prabhpreet/auth-helpers
that referenced
this pull request
Oct 12, 2023
…sr-use-storage-adapter PR supabase#609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature / chore
What is the current behavior?
CookieAuthStorageAdapterdoesn't await the response ofthis.getCookie(key).This limits how much it can be extended as methods like
chrome.cookies.getAllalways run asynchronously.What is the new behavior?
getItemin theCookieAuthStorageAdapteris now an async function thatawaitsthe result ofthis.getCookie(key).This should not cause any changes in behaviour and is in line with how
getItemworks in the goTrueClient storage adapter.Additional context
My personal use case is that I'm making an adapter to use supabase auth in my extension service worker and I prefer extending
CookieAuthStorageAdapteroverStorageAdapter. I figured other people trying to extend it will run into the same issue eventually so making a PR.