chore(deps): update all outdated dependencies, and update release flow for pushing RC releases #726
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates outdated dependencies and revises the release workflow for pushing RC releases.
- Updates various dependency revisions and versions in Package.resolved
- Introduces new steps and logic in the release.yml workflow to handle release candidate creation and GitHub release publishing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Supabase.xcworkspace/xcshareddata/swiftpm/Package.resolved | Updated dependency revisions and versions to newer releases |
| .github/workflows/release.yml | Added and modified steps to calculate version numbers, determine release candidate status, and automate GitHub release creation |
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - if: ${{ steps.release.outputs }} |
There was a problem hiding this comment.
The condition is too generic; consider using an explicit check (e.g. for specific output variables) to ensure the step only runs when the expected outputs (like 'release_created' or 'prs_created') are set.
| - if: ${{ steps.release.outputs }} | |
| - if: ${{ steps.release.outputs.release_created == 'true' || steps.release.outputs.prs_created == 'true' }} |
Copilot uses AI. Check for mistakes.
| if [ "$RELEASE_CANDIDATE" = "true" ]; then | ||
| # Release please doesn't tell you the candidate version when it | ||
| # creates the PR, so we have to take it from the title. | ||
| MAIN_RELEASE_VERSION=$(node -e "console.log('${{ steps.release.outputs.pr && fromJSON(steps.release.outputs.pr).title }}'.split(' ').reverse().find(x => x.match(/[0-9]+[.][0-9]+[.][0-9]+/)))") |
There was a problem hiding this comment.
The version extraction using a Node command is complex; consider adding error handling or refactoring this logic into a separate, more readable script to ensure a valid version string is always obtained.
Copilot uses AI. Check for mistakes.
| # Use git describe tags to identify the number of commits the branch | ||
| # is ahead of the most recent non-release-candidate tag, which is | ||
| # part of the rc.<commit> value. | ||
| RELEASE_VERSION=$MAIN_RELEASE_VERSION-rc.$(node -e "console.log('$(git describe --tags --exclude rc*)'.split('-')[1])") |
There was a problem hiding this comment.
The nested command substitution inside the Node command may reduce readability and complicate troubleshooting; consider refactoring this logic to improve clarity and maintainability.
| RELEASE_VERSION=$MAIN_RELEASE_VERSION-rc.$(node -e "console.log('$(git describe --tags --exclude rc*)'.split('-')[1])") | |
| # Extract the number of commits ahead of the most recent non-release-candidate tag | |
| GIT_DESCRIBE_OUTPUT=$(git describe --tags --exclude rc*) | |
| COMMIT_COUNT=$(node -e "console.log('$GIT_DESCRIBE_OUTPUT'.split('-')[1])") | |
| RELEASE_VERSION=$MAIN_RELEASE_VERSION-rc.$COMMIT_COUNT |
Copilot uses AI. Check for mistakes.
Pull Request Test Coverage Report for Build 15423552020Details
💛 - Coveralls |
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.