pinnwand: use aware datetime objects #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
force-pushed
the
timezone-aware
branch
3 times, most recently
from
9f4fe52
to
e2af682
Compare
Deprecation warnings are being emitted about using `datetime.utcnow` and to replace those with `datetime.now(timezone.utc)`. This creates a timezone aware datetime object hence we now need to get datetime aware objects from the database as well. This seems to a bit annoying in (for example SQLite) for the backend. We use a 3rd-party package to provide us with an `UtcDateTime` type for SQLAlchemy to fix this. Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
force-pushed
the
timezone-aware
branch
from
e2af682
to
338883c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warnings are being emitted about using
datetime.utcnowand to replace those withdatetime.now(timezone.utc). This creates a timezone aware datetime object hence we now need to get datetime aware objects from the database as well.This seems to a bit annoying in (for example SQLite) for the backend.
We use a 3rd-party package to provide us with an
UtcDateTimetype for SQLAlchemy to fix this.