Skip to content

Conversation

mlokesh22
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student has correctly implemented the solutions for "Diagonal traverese.cpp" and "spiral matrix.cpp" with appropriate time and space complexities.
  • The code is generally well-structured and readable.
  • The student has included comments to explain the logic, which is good practice.

Areas for Improvement:

  • The solution for "Product of array except self.cpp" has several issues:
    • The result vector is not initialized with the correct size, leading to potential out-of-bounds errors.
    • The loop condition in the second loop is incorrect (i>=0 but using i++).
    • The i-- inside the loop causes the loop to skip elements.
    • The logic for calculating the right product is flawed.
  • The student should test their code with sample inputs to catch these errors.
  • The student should pay more attention to loop conditions and array indexing to avoid such mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants