Update configuration.html.markerb #2192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to a builder that is still maintained. Not sure if the separate buildpacks parameter is needed, but kept that as as separate examp.e Also note, I wonder why you don't fall back to buildpacks if Dockerfile does not exist🤷♂️ At least it could do a priming build if it succeeds and if so, then drop this line to the tly.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changed to a builder that is still maintained.
Not sure if the separate buildpacks parameter is needed, but kept that as as separate example.
Preview
Related Fly.io community and GitHub links
Notes
I wonder why you don't fall back to buildpacks if Dockerfile does not exist🤷♂️ At least it could do a priming build if it succeeds and if so, then drop this line to the tly.toml. Tried your platform first time today and experience was not very good. With your docs and google I expected things would work and then from docs I got snippet that brought me outdated buildpack. Implicitly using up-to-date buildpacks might make me try this again (or promote this service to our developer audience)