feat: add hikari logs to otel #179
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -52,7 +53,7 @@ void loadConfig(JsonObject jsonConfig, Set<LOG_LEVEL> logLevels, TenantIdentifie | |||
| // then this function should throw an error since this is a misconfig from ther user's side. | |||
| void assertThatConfigFromSameUserPoolIsNotConflicting(JsonObject otherConfig) throws InvalidConfigException; | |||
|
|
|||
| void initFileLogging(String infoLogPath, String errorLogPath); | |||
| void initFileLogging(String infoLogPath, String errorLogPath, OtelProvider otelProvider); | |||
There was a problem hiding this comment.
API Breaking Change: Modifying the initFileLogging method signature adds a required parameter that will break backward compatibility with existing implementations of the Storage interface. Consider one of these approaches:
- Create an overloaded method that maintains the original signature and internally calls the new implementation with a default value
- Provide a default implementation (if using Java 8+)
- Ensure all implementations are updated simultaneously with this change
This change requires careful coordination to prevent runtime errors when existing code calls this interface method.
| void initFileLogging(String infoLogPath, String errorLogPath, OtelProvider otelProvider); | |
| void initFileLogging(String infoLogPath, String errorLogPath); | |
| void initFileLogging(String infoLogPath, String errorLogPath, OtelProvider otelProvider); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
CHANGELOG.md
Outdated
| @@ -7,6 +7,10 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [8.0.3] | |||
There was a problem hiding this comment.
Version inconsistency between changelog and build.gradle
There's a discrepancy in the version numbers:
- Changelog shows
8.0.3 build.gradleis being updated to8.1.0
These should be aligned to maintain clear versioning. Since adding OpenTelemetry support appears to be a feature addition, the 8.1.0 version in build.gradle follows semantic versioning correctly. Consider updating the changelog to match this version number.
| ## [8.0.3] | |
| ## [8.1.0] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
fix: update config from env
Summary of change
(A few sentences about this PR)
Related issues
Checklist for important updates
build.gradlegit tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR