Add UVC for video gadget #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surban
requested changes
Dec 5, 2024
surban
approved these changes
Dec 5, 2024
| /// Create a subdirectory and its parent directories. | ||
| pub fn create_dir_all(&self, name: impl AsRef<Path>) -> Result<()> { | ||
| let path = self.property_path(name)?; | ||
| log::debug!("creating directorys {}", path.display()); |
There was a problem hiding this comment.
Suggested change
| log::debug!("creating directorys {}", path.display()); | |
| log::debug!("creating directories {}", path.display()); |
|
Thanks! Seems to have been quite the effort to implement all these settings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the UVC gadget support.
I think the API makes sense for gadget creation. The UVC is a little different from the others in that it requires a userspace application to support even enumeration.
I tested with https://gitlab.freedesktop.org/camera/uvc-gadget. Creating the gadget then running
uvc-gadget uvc.usb-gadget0-0(where 'uvc.usb-gadget0-0' is the function dir) will enumerate with my macOS host - without the application it won't. One can open a camera application and open the device. The default just shows a test pattern but can pass-i imageor-s dirfor slideshow.Would be cool to make a Rust version of uvc-gadget but think it's beyond the scope of this crate or at least this PR since it would almost certainly add a few extra dependencies. It feels like more of a separate bin crate or perhaps workspace crate. Will explore.