-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microshift in CI #759
Add support for Microshift in CI #759
Conversation
Signed-off-by: Vibhu Prashar <[email protected]>
@vprashar2929 new microshift integration test failed: https://github.com/sustainable-computing-io/kepler/actions/runs/5437485041/jobs/9888072090?pr=759
|
Yes, currently it will fail as there is an open PR in Kepler-action for updating the logic. Once that is merged then CI will work fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will suggestion as bump up version in another PR.
As split this PR into 2 parts.
- as adjust for logic, as add new verify.sh shell
- bump up version to add microshift support.
- name: use kepler action for kind cluster build | ||
uses: sustainable-computing-io/kepler-action@v0.0.0 | ||
- name: use kepler action for cluster build | ||
uses: sustainable-computing-io/kepler-action@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rootfs, @vprashar2929 for dev branch, we should keep this to main, for release we should use a release branch. Hence before we bump up version for kepler-action and local-dev-cluster, we should keep it as v0.0.0 and keep this PR open for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hence I will suggestion as bump up version in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure bumping up the version in another PR sounds good. Till that time I will keep it as v0.0.0
hack/cluster-deploy.sh
Outdated
[ ! -d "${MANIFESTS_OUT_DIR}" ] && echo "Directory ${MANIFESTS_OUT_DIR} DOES NOT exists. Run make generate first." | ||
|
||
if [ "$CLUSTER_PROVIDER" == "microshift" ] | ||
then | ||
kubectl label node --all sustainable-computing.io/kepler='' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should considering change https://github.com/sustainable-computing-io/kepler/blob/main/manifests/config/exporter/patch/patch-ci.yaml
hack/cluster-up.sh
Outdated
echo "download local-dev-cluster with version v0.0.0" | ||
git clone -b v0.0.0 https://github.com/sustainable-computing-io/local-dev-cluster.git --depth=1 | ||
echo "download local-dev-cluster with latest version" | ||
git clone https://github.com/sustainable-computing-io/local-dev-cluster.git --depth=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related with version bump up. Same comments here for version control.
to go with a new release or not for https://github.com/sustainable-computing-io/local-dev-cluster as k3s support |
One more thing I would like to add is when I was working on adding micro shift to CI I realized that building Kepler image takes more than 10GB of disk space(Dependent Images) on GH runner and we are using the same runner to create cluster, build image and deploy Kepler. Since the default disk size for GH runner is around 14GB. This make's difficult for the running cluster to run properly as I have seen the case where the cluster had to evict the running pods in order to reclaim the disk space because of @rootfs @SamYuan1990 @marceloamaral Any thoughts on this? |
@vprashar2929 that sounds a good idea. Would you like to have multiple jobs, kind/microshift/and potentially k3s in different jobs? How about we divide the flow into image build and image test? The image build job builds and uploads kepler image artifacts and the image test steps download the image and run kind/microshift/k3s in their runners. |
Yes, @rootfs I am also thinking of the same flow to have a job that builds and uploads Kepler image artifacts and another which uses our Kepler-action to bring up kind/microshift/k3s clusters, deploy Kepler, and run e2e test's on it. |
@SamYuan1990 is the request done? |
bdddd69
to
6c5952e
Compare
Signed-off-by: Vibhu Prashar <[email protected]>
6c5952e
to
0965a41
Compare
Incorporated review comments.🙂 |
The current integration test will fail as I have reverted the bump up's in version for sustainable-computing-io/kepler-action. The v0.0.0 doesn't contain the functionality to launch microshift cluster. |
@vprashar2929 got a CI failure |
Yes @rootfs the CI will fail as we using |
Since we have added support for having microshift as a cluster in the local-dev-cluster repo and updated the kepler-action as well This PR is in continuation to add support for running Kepler integration tests on microshift cluster.
Dependency:
There is an open PR in Kepler-action to update some recent changes done to local-dev-cluster repo.
CC: @SamYuan1990 @rootfs