Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create methods on DAGModel class #22

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

paulromano
Copy link
Contributor

This PR builds on #13 to providecreate_group, create_volume and create_surface methods on the DAGModel class that simply delegate to the underlying DAGSet.create and Group.create classmethods.

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few docstring suggestions to remind users that the new groups are created empty, and that the volumes and surfaces are really sets.

Also, another test suggestion, but not 100% convinced that it adds to the coverage.

dagmc/dagnav.py Outdated Show resolved Hide resolved
dagmc/dagnav.py Outdated Show resolved Hide resolved
dagmc/dagnav.py Outdated Show resolved Hide resolved
test/test_basic.py Show resolved Hide resolved
@gonuke
Copy link
Member

gonuke commented Apr 26, 2024

LGTM - I'm ready to see this merged

Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed @gonuke. Thanks @paulromano!

@pshriwise pshriwise merged commit 1141d5d into svalinn:main Apr 26, 2024
1 check passed
@paulromano paulromano deleted the create-methods branch April 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants