Skip to content

fix: add ignoreLocalVariables to prefer-svelte-reactivity rule to avoid false positives #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Jul 23, 2025

close: #1271

Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 3b5b904

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marekdedic
Copy link
Contributor

marekdedic commented Jul 23, 2025

Thanks for taking this on. I think we should be careful, though - this should still report even when ignoring local variables:

function fn(): Set<string> {
  const local = new Set();
  local.add("Hello");
  return local;
}

Arguably, even this should report (and probably doesn't even currently...):

function fn(): Set<string> {
  const local = new Set();
  return local;
}

(similarly for class members...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte/prefer-svelte-reactivity triggers inside non-reactive functions (e.g., URL, Date, Set usage)
2 participants