-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: prevent ownership warnings if the fallback of a bindable is used #15720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5e02a98
fix: prevent ownership warnings if the fallback of a bindable is used
paoloricciuti 4f7c3bd
fix: filter out symbol from own keys
paoloricciuti 7e95260
fix: don't create sources for `BINDABLE_FALLBACK_SYMBOL`
paoloricciuti 8fda58a
fix: use strategy suggested by actually competent person aka @dummdidumm
paoloricciuti 24d4df3
chore: rename function
paoloricciuti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'svelte': patch | ||
--- | ||
|
||
fix: prevent ownership warnings if the fallback of a bindable is used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...elte/tests/runtime-runes/samples/ownership-invalid-binding-bindable-fallback/Child.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<script> | ||
const { test = $bindable() } = $props(); | ||
</script> | ||
|
||
{test} |
7 changes: 7 additions & 0 deletions
7
...lte/tests/runtime-runes/samples/ownership-invalid-binding-bindable-fallback/Parent.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<script> | ||
import Child from './Child.svelte'; | ||
|
||
let { test = $bindable({}) } = $props(); | ||
</script> | ||
|
||
<Child bind:test /> |
11 changes: 11 additions & 0 deletions
11
...svelte/tests/runtime-runes/samples/ownership-invalid-binding-bindable-fallback/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { test } from '../../test'; | ||
|
||
export default test({ | ||
mode: ['client'], | ||
compileOptions: { | ||
dev: true | ||
}, | ||
async test({ warnings, assert }) { | ||
assert.deepEqual(warnings, []); | ||
} | ||
}); |
5 changes: 5 additions & 0 deletions
5
...velte/tests/runtime-runes/samples/ownership-invalid-binding-bindable-fallback/main.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<script> | ||
import Parent from './Parent.svelte'; | ||
</script> | ||
|
||
<Parent /> |
8 changes: 8 additions & 0 deletions
8
...te/tests/runtime-runes/samples/ownership-invalid-mutation-bindable-fallback/Parent.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<script> | ||
let { test = $bindable({}) } = $props(); | ||
</script> | ||
|
||
<button onclick={()=>test = {}}></button> | ||
<button onclick={()=>test.test = {}}></button> | ||
|
||
{test} |
23 changes: 23 additions & 0 deletions
23
...velte/tests/runtime-runes/samples/ownership-invalid-mutation-bindable-fallback/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { flushSync } from 'svelte'; | ||
import { test } from '../../test'; | ||
|
||
export default test({ | ||
mode: ['client'], | ||
compileOptions: { | ||
dev: true | ||
}, | ||
async test({ warnings, assert, target }) { | ||
const [btn, btn2] = target.querySelectorAll('button'); | ||
flushSync(() => { | ||
btn2.click(); | ||
}); | ||
assert.deepEqual(warnings, []); | ||
flushSync(() => { | ||
btn.click(); | ||
}); | ||
flushSync(() => { | ||
btn2.click(); | ||
}); | ||
assert.deepEqual(warnings, []); | ||
} | ||
}); |
5 changes: 5 additions & 0 deletions
5
...elte/tests/runtime-runes/samples/ownership-invalid-mutation-bindable-fallback/main.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<script> | ||
import Parent from './Parent.svelte'; | ||
</script> | ||
|
||
<Parent /> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While that's all correct the function name now is confusing because it no longer is what this check is about.
is_bound_or_unset
maybe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm yeah let me change that, even tho I read that as "if it's unset is automatically bound" but maybe it's better to rename it