refactor(toasts): improve a11y and code quality based on sonar findings

svierk · Oct 19, 2024 · 838d674 · 838d674
1 parent dded929
commit 838d674
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/app/app.component.html b/src/app/app.component.html
@@ -5,16 +5,16 @@
 <app-toaster></app-toaster>
 
 <!-- Toolbar -->
-<div class="toolbar" role="banner">
+<header class="toolbar">
   <img
     width="40"
     alt="Angular Logo"
     src="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTAgMjUwIj4KICAgIDxwYXRoIGZpbGw9IiNERDAwMzEiIGQ9Ik0xMjUgMzBMMzEuOSA2My4ybDE0LjIgMTIzLjFMMTI1IDIzMGw3OC45LTQzLjcgMTQuMi0xMjMuMXoiIC8+CiAgICA8cGF0aCBmaWxsPSIjQzMwMDJGIiBkPSJNMTI1IDMwdjIyLjItLjFWMjMwbDc4LjktNDMuNyAxNC4yLTEyMy4xTDEyNSAzMHoiIC8+CiAgICA8cGF0aCAgZmlsbD0iI0ZGRkZGRiIgZD0iTTEyNSA1Mi4xTDY2LjggMTgyLjZoMjEuN2wxMS43LTI5LjJoNDkuNGwxMS43IDI5LjJIMTgzTDEyNSA1Mi4xem0xNyA4My4zaC0zNGwxNy00MC45IDE3IDQwLjl6IiAvPgogIDwvc3ZnPg=="
   />
   <span>Welcome</span>
-</div>
+</header>
 
-<div class="content" role="main">
+<main class="content">
   <!-- Highlight Card -->
   <div class="card highlight-card card-small">
     <svg id="rocket" xmlns="http://www.w3.org/2000/svg" width="101.678" height="101.678" viewBox="0 0 101.678 101.678">
@@ -87,6 +87,6 @@ <h2>Toasts</h2>
       fill="#eee"
     />
   </svg>
-</div>
+</main>
 
 <router-outlet></router-outlet>
diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -12,7 +12,7 @@ export class AppComponent {
 
   EventTypes = EventTypes;
 
-  constructor(private toastService: ToastService) {}
+  constructor(readonly toastService: ToastService) {}
 
   showToast(type: EventTypes) {
     switch (type) {

diff --git a/src/app/components/toaster/toaster.component.ts b/src/app/components/toaster/toaster.component.ts
@@ -12,8 +12,8 @@ export class ToasterComponent implements OnInit {
   currentToasts: ToastEvent[] = [];
 
   constructor(
-    private toastService: ToastService,
-    private cdr: ChangeDetectorRef
+    readonly toastService: ToastService,
+    readonly cdr: ChangeDetectorRef
   ) {}
 
   ngOnInit() {

diff --git a/src/app/services/toast.service.ts b/src/app/services/toast.service.ts
@@ -8,7 +8,7 @@ import { ToastEvent } from '../models/toast-event';
 })
 export class ToastService {
   toastEvents: Observable<ToastEvent>;
-  private _toastEvents = new Subject<ToastEvent>();
+  readonly _toastEvents = new Subject<ToastEvent>();
 
   constructor() {
     this.toastEvents = this._toastEvents.asObservable();