completedAt not archivedAt #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzewail
reviewed
Nov 15, 2022
| @@ -94,7 +94,7 @@ | |||
| "string" | |||
| ] | |||
| }, | |||
| "archivedAt": { | |||
| "completedAt": { | |||
There was a problem hiding this comment.
is there a reason this is a string and not some date type?
There was a problem hiding this comment.
yeah previously we have it in a anyOf: [null, datetime type] kinda thing, but that was the reason we didn't have those columns in our dwh
#1
nzewail
approved these changes
Nov 15, 2022
like test the schema against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have
createdAt,updatedAtandcompletedAtfor aSubmissionbut no
archivedAthttps://www.useanvil.com/docs/api/graphql/reference/#definition-Submission