Support primitive type with format in response #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Signed-off-by: sdghchj <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1754 +/- ##
==========================================
- Coverage 83.40% 83.38% -0.03%
==========================================
Files 16 16
Lines 3868 3875 +7
==========================================
+ Hits 3226 3231 +5
- Misses 544 545 +1
- Partials 98 99 +1 ☔ View full report in Codecov by Sentry. |
ubogdan
reviewed
Oct 20, 2024
| NUMBER: {"float": true, "double": true}, | ||
| STRING: {"byte": true, "binary": true, "date": true, "date-time": true, "password": true}, | ||
| } | ||
|
|
There was a problem hiding this comment.
Why don't use the reverse way
var validPrimitiveFormat = map[string]string{
"int32": "INTEGER"
"int64": "INTEGER"
"float": "NUMBER"
....
}and the condition from operations.go
if !validPrimitiveFormat[refType] != schemaType {| err := operation.ParseComment(comment, nil) | ||
| assert.Error(t, err) | ||
|
|
||
| comment = `@Success 200 {integer} int32 "response with format"` |
There was a problem hiding this comment.
This is a stupid corner case , Can you show me an example how you send and receive an int32 over an HTTP request ? :)
Usually the response is a JSON object, not a string value 🔦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Support primitive type with format in response
Relation issue
#1714