-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow for welcoming first-time contributors #55
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think this workflow design will work because GitHub Actions will be disabled for first-time contributors and thus the action will not trigger on the `pull_request_target
I am reading through this and getting the impression that the limitation applies to workflow runs — regardless of whether they depend on actions. But the note says that |
8d31115
to
66b4ebb
Compare
66b4ebb
to
084eab0
Compare
I’m sorry. I meant to remove that comment after I realized that you’re using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I would like @shahmishal to review this as well because it’s a new workflow.
Sure, I’d like that too! Thanks for reviewing, Alex. |
pull_request_message: | ||
description: > | ||
The Markdown message to comment when a contributor creates their first | ||
pull request. | ||
type: string | ||
required: false | ||
issue_message: | ||
description: > | ||
The Markdown message to comment when a contributor creates their first | ||
issue. | ||
type: string | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide a default message for both? Would avoid every repo to define its own custom message. Maybe even going one step further do we want each repo to customise this really? If so how do you expect them to customise this?
I tested the workflow in my swift fork, albeit without the first-time contributor condition. Once this lands, we can use the contributor experience repo to further test it against pull requests from forks.