[lldb][CI] Disable failing tests on linux #10043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
| @@ -10,7 +10,7 @@ | |||
| class TestDbgInfoContentDeque(TestBase): | |||
| @add_test_categories(["libc++"]) | |||
| @skipIf(compiler=no_match("clang")) | |||
| @skipIf(compiler="clang", compiler_version=["<", "12.0"]) | |||
| @skipIf(compiler="clang", compiler_version=["<", "12.0"], oslist=["linux"]) | |||
There was a problem hiding this comment.
Are these "and" or "or"? You may need to do this instead:
Suggested change
| @skipIf(compiler="clang", compiler_version=["<", "12.0"], oslist=["linux"]) | |
| @skipIf(compiler="clang", compiler_version=["<", "12.0"]) | |
| @skipIf(oslist=["linux"]) |
There was a problem hiding this comment.
I was hoping for "and" but this is better solution, I'll change the other tests to match.
chelcassanova
force-pushed
the
disable-failing-linux-tests
branch
from
1840e11 to
1445eb8
Compare
|
I'm confused:
|
|
No, your commit is in the right place. |
|
@swift-ci test |
| @@ -6,6 +6,7 @@ | |||
|
|
|||
|
|
|||
| class TestCase(TestBase): | |||
| @skipIf(oslist=["linux"]) | |||
There was a problem hiding this comment.
This looks like it's dangling, it should decorate the appropriate test_ method.
This commit adds skipIfs in order to disable tests that are failing on the Green Dragon CI Ubuntu bots. rdar://145000025
chelcassanova
force-pushed
the
disable-failing-linux-tests
branch
from
1445eb8 to
eb41d98
Compare
|
@swift-ci please test |
| @@ -11,7 +11,7 @@ | |||
| class TestDbgInfoContentList(TestBase): | |||
| @add_test_categories(["libc++"]) | |||
| @skipIf(compiler=no_match("clang")) | |||
| @skipIf(compiler="clang", compiler_version=["<", "12.0"]) | |||
| @skipIf(compiler="clang", compiler_version=["<", "12.0"], oslist=["linux"]) | |||
There was a problem hiding this comment.
I think this is still not what you intend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds skipIfs in order to disable tests that are failing on the Green Dragon CI Ubuntu bots.
rdar://145000025