Add support for availability-style features #10098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch doesn't include the codegen and serialization changes that are needed to support the availability-style features. rdar://137999979
|
#9815 has the codegen and serialization changes. |
ahatanaka
requested review from
jroelofs,
nkcsgexi,
ributzka,
tshortli,
rjmccall and
devincoughlin
jroelofs
reviewed
Feb 24, 2025
| else if (Kind == "dyn") { | ||
| llvm_unreachable("dyn not supported"); | ||
| } else | ||
| llvm_unreachable("invalid FeatureAvailKind"); |
There was a problem hiding this comment.
unreachable shouldn't be used for diagnostics when the user could hit them
jroelofs
reviewed
Feb 24, 2025
| #ifndef __FEATURE_AVAILABILITY_H | ||
| #define __FEATURE_AVAILABILITY_H | ||
|
|
||
| #include <stdint.h>> |
jroelofs
reviewed
Feb 24, 2025
| @@ -3999,6 +4008,23 @@ std::optional<AvailabilitySpec> Parser::ParseAvailabilitySpec() { | |||
| Actions.CodeCompletion().CodeCompleteAvailabilityPlatformName(); | |||
| return std::nullopt; | |||
| } | |||
|
|
|||
| if (Tok.is(tok::identifier) && GetLookAheadToken(1).is(tok::equal)) { | |||
There was a problem hiding this comment.
suggest: tok::colon instead of tok:equal, so it matches the feat: <feature> style ones
jroelofs
reviewed
Feb 24, 2025
| ObjCShouldCallSuper(false), ObjCIsDesignatedInit(false), | ||
| ObjCWarnForNoDesignatedInitChain(false), ObjCIsSecondaryInit(false), | ||
| ObjCWarnForNoInitDelegation(false), NeedsCoroutineSuspends(true), | ||
| FoundImmediateEscalatingExpression(false), ErrorTrap(Diag) {} |
There was a problem hiding this comment.
suggest to not clang-format this after adding the new line, so we reduce the downstream diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch doesn't include the codegen and serialization changes that are needed to support the availability-style features.
rdar://137999979