[🍒][-Wunsafe-buffer-usage] Accept calls to some libc functions with annotated arguments & Let libc warnings yield to bounds attributes #10182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes For a call to an unsafe libc function, do not warn about it if its callee function has any bounds attributes. Because we can verify the safety of the call using bounds attributes. (rdar://140138380)
…tated arguments (#10088) * [-Wunsafe-buffer-usage] Accept calls to some libc functions with annotated arguments - `printf`, `fprintf` `snprintf` functions accept `__null_terminated` - `snprintf` function accepts `__counted_by/__sized_by` - functions consuming a single string pointer like `strlen` or `atoi` accept `__null_terminated` Generalized `isCountAttributedPointerArgumentSafe` so that it is shared by interoperation gadgets and the unsafe libc gadget. (A follow-up change to rdar://138798346)
|
Cherry-picking #10088, which depends on "[C++ Safe Buffers] Let libc warnings yield to bounds attributes" that was forgotten to be cherry-picked to stable/20240723. |
|
@swift-ci test |
|
@swift-ci test llvm |
|
@swift-ci test |
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printf,fprintfsnprintffunctions accept__null_terminatedsnprintffunction accepts__counted_by/__sized_bystrlenoratoiaccept
__null_terminatedGeneralized
isCountAttributedPointerArgumentSafeso that it isshared by interoperation gadgets and the unsafe libc gadget.
(A follow-up change to rdar://138798346)
For a call to an unsafe libc function, do not warn about it if its
callee function has any bounds attributes. Because we can verify the
safety of the call using bounds attributes.
(rdar://140138380)