Skip to content

[lldb] Update for extension binding cleanup #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable/20240723
Choose a base branch
from
Open

[lldb] Update for extension binding cleanup #11189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lldb/source/Plugins/ExpressionParser/Swift/SwiftASTManipulator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,11 +848,15 @@ GetPatternBindingForVarDecl(swift::VarDecl *var_decl,

// Since lldb does not call bindExtensions, must ensure that any enclosing
// extension is bound
// FIXME: This won't correctly handle cases that rely on other extensions
// being bound first, e.g for nested types defined in extensions.
for (auto *context = containing_context; context;
context = context->getParent()) {
if (auto *d = context->getAsDecl()) {
if (auto *ext = swift::dyn_cast<swift::ExtensionDecl>(d))
ext->computeExtendedNominal();
if (auto *ext = swift::dyn_cast<swift::ExtensionDecl>(d)) {
if (!ext->hasBeenBound())
ext->setExtendedNominal(ext->computeExtendedNominal());
}
}
}
swift::Type type = containing_context->mapTypeIntoContext(
Expand Down