Re-land [Incremental Builds] Separately check whether we can skip 'emit-module' on an incremental module-only build #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' on an incremental module-only build Resolves rdar://151626629
|
@swift-ci test |
cachemeifyoucan
approved these changes
Jun 5, 2025
owenv
approved these changes
Jun 5, 2025
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally landed in #1905 and reverted in #1916 due to an intermittently-failing test it caused. This is a re-application of the original change with an added test fix. The
testExplicitModuleBuildDoesNotSkipPrecompiledModulesWhenOnlyVerificationIsInvalidatedwas a bit too fast with the new module up-to-date checking after the inputs got generated, for the granularity ofstatcalls on Linux, so this change adds a wait to this test.Resolves rdar://151626629