[Proposal] Base64 urlencoding and omitting padding options #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-pitch-add-base64-options
branch
from
224136d to
e38461d
Compare
parkera
reviewed
Mar 3, 2025
| extension Data.Base64EncodingOptions { | ||
| /// Use the base64url alphabet to encode the data | ||
| @available(FoundationPreview 6.2, *) | ||
| public static var base64UrlAlphabet: Base64EncodingOptions { get } |
There was a problem hiding this comment.
Spelling nitpick - I think this should be capitalized like base64URLAlphabet (same for others that use URL).
fabianfett
force-pushed
the
ff-pitch-add-base64-options
branch
from
e38461d to
777ce4c
Compare
|
@swift-ci please test |
itingliu
reviewed
Mar 7, 2025
| /// | ||
| /// The decoding will fail if any other invalid character is found in the encoded data. | ||
| @available(FoundationPreview 6.2, *) | ||
| public static var ignoreWhitespaceCharacters: Base64EncodingOptions { get } |
There was a problem hiding this comment.
please fix the name scope here (encoding options vs decoding options and the extension they belong)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.