Remove unknown context from PredicateTests.Object type name #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
This was referenced Jun 18, 2025
Merged
Azoy
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows swift-ci is currently failing on the swift repo because the name of
Objectproduced byFoundationEssentialsdoes not match the name produced by the unit tests (the context of the type is different, inFoundationEssentialsit's unknown but in the unit test file it's based on the file name). To resolve this, I movedObjectto the global scope and marked it asinternalso its name is consistentlyFoundationEssentialsTests.PredicateTestObjectinstead of including a potentially changing intermediate context scope.