[DRAFT] Migrate format parsers to UTF8Span #1370
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be better understood by looking at the 3 commits individually (otherwise it's a big diff).
First commit gets us out of passing down the original
Stringvalue all the way through for the purposes of diagnostics.Second commit untangles all diagnostic code from the low-level scanner/lexer style code, while keeping the behavior and basic code structure unchanged. This shows us the basic patterns that we could surface as API on our Span-like types and should spark some interesting designs and discussions.
Third commit just migrates over to
UTF8Span, albeit via aguard #available else { fatalError() }pattern. Not sure if that's the way we want to go.Note that I haven't tested this fully yet.