-
Notifications
You must be signed in to change notification settings - Fork 43
Split options dialog into 4 steps #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CC @compnerd |
Hmm, can we make it a hyperlinked pagination? Something like: Core
SDKs
|
We could. There is a "CommandLink" element, that is basically a hyper link that acts as a button. but i do not think it adds much value to clarity. this flow is not very different from what git for windows does today. a series of questions, and then install page. I think a simple and familiar interface is better than trying to over engineer it |
for context @compnerd, it looks something like this: which i do not find it very ascetically appealing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Not sure how you want to do this, but it might be good to allow the user to select which platforms they want to install instead of pushing them through that page every time. If we ever added a Linux SDK on Windows, that would be another page on the installer so it might get cumbersome. Otherwise this looks pretty good.
The difference is that this is not like the git flow. This is explicitly an options dialog that the user needs to navigate to in order to select features. It is not about the defaults. The Git installer has a feature tree. |
we can make it so. we just need to make the first option page the first page in the installer instead of "Install".
so this is where it gets complicated. Git is just an msi (a single Package in Wix terms). so the built in Wix UI gives the feature tree for free. we are using a chain of packages (a Bundle), and for these there a handful of UI options we can choose from, and none is a feature tree. if we want a feature tree there are two options. one option is to use one of the MSIs and mark it with |
An alternative if you want a feature tree is to use a BAFunctions DLL to fill the tree control and respond to the notifications to set the properties that control package state. It would be a shame to introduce a .NET dependency just for the installer. |
Yes, this was exactly my thought and reasoning.
This would be unfortunate. Something that I've gotten a fair amount of positive feedback was the simplicity of the installer. I am somewhat hesitant to roll back on that. It feels like it should be possible to have a polished experience with the common path being really simple (we should aim to have the majority of users be happy with the default configuration). @barnson thank you for the suggestion! That definitely sounds interesting and seems worth exploring. Would you happen to know of any examples that you could point to? |
https://github.com/wixtoolset/wix/tree/main/src/test/burn/TestData/Manual/BafThmutilTesting has some UI manipulation. |
We are getting strapped for space in the current installer options window. To give us more room, this change splits the Options Page into 4, each with a specific theme. 1. Install Root, 2. Tools, 3. Windows SDK components, and 4. Android SDK components.
See this video for the new flow after the change:
Changes include: