use serial queue to order repository lookups #7076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
radar/118239206
branch
from
bb50625 to
af73f88
Compare
neonichu
reviewed
Nov 10, 2023
tomerd
force-pushed
the
radar/118239206
branch
from
af73f88 to
edcc358
Compare
motivation: lookup callback could race and lead to broken resolution. the actual lookup code assume no-cocurrent access but get called on a concurrent queue which could lead to races changes: * change the repository lookup callback queue to a serial one rdar://118239206
tomerd
force-pushed
the
radar/118239206
branch
from
edcc358 to
f308e2b
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: lookup callback could race and lead to broken resolution. the actual lookup code assume no-cocurrent access but get called on a concurrent queue which could lead to races
changes:
rdar://118239206