-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic linking on Linux via Artifactbundles #8249
Open
tayloraswift
wants to merge
16
commits into
swiftlang:main
Choose a base branch
from
tayloraswift:dynamic-libraries-for-linux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support dynamic linking on Linux via Artifactbundles #8249
tayloraswift
wants to merge
16
commits into
swiftlang:main
from
tayloraswift:dynamic-libraries-for-linux
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14dd2a6
to
d01f6ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proof-of-concept for enabling self-managed dynamic library dependencies on Linux!
Motivation:
see Forums discussion, #5714
Modifications:
ArtifactType
called “library
”, which can be used ininfo.json
inside an Artifactbundle. variant/triple checking is not implemented yet, and we expect this to be very limited and geared towards self-managed deployment use cases, as we intentionally do not want to design a compatibility checking system that covers all possible host–target combinations of “Linux”.adds logic to
Sources/Build/BuildPlan/BuildPlan+Swift.swift
that injects the necessary.swiftmodule
search paths to theswiftc
build command.adds logic to
Sources/Build/BuildPlan/BuildPlan+Product.swift
that populates the necessary linker flags to compile products that include dependencies on non-XCFramework binary targetsdoes a small amount of refactoring around the additions i made, in an effort to leave the code base in a slightly better shape than i found it in
Result:
SwiftPM can now dynamically link binary library dependencies into executables on Linux, although the executables of course will require the shared libraries to be installed in the expected locations to actually run.
sample manifest:
sample Artifactbundle