Skip to content

[WIP] Fix for trait-guarded deps being included in resolution #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bripeticca
Copy link
Contributor

Trait-guarded dependencies were still being considered during dependency resolution, when they should be excluded if they aren't being used in any other scenario.

Modifications:

Since we have the --experimental-prune-unused-dependencies feature behind an experimental flag, we'll now consider an alternate path that will prune trait-guarded package dependencies from the dependency graph if and only if said dependency is not used in any other unguarded context.

Result:

Trait-guarded dependencies are excluded from dependency resolution.

@bripeticca
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant