Add build prebuilts support for any version of swift-syntax. #8994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hardcoding of the contents of the prebuilt libraries. Adds a --version argument to specify which versions of swift-syntax you want to build for. You can have multiple of these. Also removes the hardcoding of the list of products that go into the library. Instead we ask the package for it's list of library products and add them all.
dschaefer2
requested review from
jakepetroules,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
| let buildDir = scratchDir.appending("release") | ||
| let srcModulesDir = buildDir.appending("Modules") | ||
| let prebuiltDir = stageDir.appending(repo.url.lastPathComponent) | ||
| try await shell("git clone https://github.com/swiftlang/swift-syntax.git", cwd: srcDir) |
There was a problem hiding this comment.
not new code but we should be avoiding shell where possible in order to avoid injections, especially where the command is not a string literal
jakepetroules
approved these changes
Aug 6, 2025
|
@swift-ci please test windows |
|
Waiting to do a little more testing on all the platforms before pushing this. |
dschaefer2
added a commit
to dschaefer2/swift-package-manager
that referenced
this pull request
Aug 11, 2025
…ng#8994) Removes the hardcoding of the contents of the prebuilt libraries. Adds a --version argument to specify which versions of swift-syntax you want to build for. You can have multiple of these. We add a sample build.sh script to the folder to show an example, including finding the most recent prerelease of 602. Also removes the hardcoding of the list of products that go into the library. Instead we ask the package for its list of library products and add them all. Finally, removes the header files since SwiftPM now hooks up the include paths to the CModules from the source in the checkouts.
dschaefer2
added a commit
that referenced
this pull request
Aug 12, 2025
…9011) Removes the hardcoding of the contents of the prebuilt libraries. Adds a --version argument to specify which versions of swift-syntax you want to build for. You can have multiple of these. We add a sample build.sh script to the folder to show an example, including finding the most recent prerelease of 602. Also removes the hardcoding of the list of products that go into the library. Instead we ask the package for its list of library products and add them all. Finally, removes the header files since SwiftPM now hooks up the include paths to the CModules from the source in the checkouts. This is needed in 6.2 to support prebuilts generated with that version of the toolchain. I have tested this on all three host platforms including all Linux distros with both architectures and swift-syntax 600, 601, and the latest prerelease of 602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hardcoding of the contents of the prebuilt libraries.
Adds a --version argument to specify which versions of swift-syntax you want to build for. You can have multiple of these. We add a sample build.sh script to the folder to show an example, including finding the most recent prerelease of 602.
Also removes the hardcoding of the list of products that go into the library. Instead we ask the package for its list of library products and add them all.
Finally, removes the header files since SwiftPM now hooks up the include paths to the CModules from the source in the checkouts.