[6.2][Concurrency] NonisolatedNonsendingByDefault: Except @Test test-cases and $ prefixed declarations from migration
#82276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e swift-testing test cases The execution of these functions is controlled by the testing framework and it's okay if their behavior changes when the feature flag is enabled. Resolves: rdar://152687527 (cherry picked from commit f2f5d23)
…e `$` prefixed declarations These are special declarations that are synthesized by the compiler or a macro and warnings about them are non-actionable. (cherry picked from commit 17976c7)
|
@swift-ci please test |
bnbarham
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82229
Explanation:
Prevents
nonisolated(nonsending)feature migration from applying to@Testannotated and compiler/macro synthesized declarations.@Testasynchronous functionsThe execution of these functions is controlled by the testing
framework and it's okay if their behavior changes when the feature
flag is enabled.
$prefix functions declarationsThese are special declarations that are synthesized by the compiler
or a macro and warnings about them are non-actionable.
Resolves: rdar://152687527
Main Branch PR: [Concurrency] NonisolatedNonsendingByDefault: Except
@Testtest-cases and$prefixed declarations from migration #82229Risk: Very Low. The change applies to migration mode of the feature that is not enabled by default.
Reviewed By: @grynspan @stmontgomery @AnthonyLatsis
Testing: No testing since it's a framework/synthesis specific change that is hard to unit test.