[6.2] Fix a lifetime dependence diagnostic #82810
Merged
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LifetimeDescriptor::getName()` can crash if the descriptor had a `self`. Replace with `LifetimeDescriptor::getString()` (cherry picked from commit 6d0a6d2)
|
@swift-ci test |
tbkka
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LifetimeDescriptor::getName()can crash if the descriptor had aself.Replace with
LifetimeDescriptor::getString()(cherry picked from commit 6d0a6d2)
--- CCC ---
Explanation: Fixes a compiler crash when reporting a lifetime diagnostic error.
Scope: This only affects adopters of experimental but supported @_lifetime syntax. The following sytax would crash:
This only occurs with invalid input, but it is easy to make this mistake because we have diagnostics suggesting this syntax when the method is mutating. And it is common to convert methods between mutating and nonmutating forms.
Radar/SR Issue: rdar://155056801 ([nonescapable] compiler crash on invalid input: @Lifetime(self: &self))
main PR: #82787
Risk: Low. This change only touches the diagnostic output.
Testing: Added source-level unit test.
Reviewer: Meghana Gupta (author)