Skip to content

[6.2] [Runtime] Don't fail conformances when the global actor hook is missing #82816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Jul 5, 2025

When the concurrency library's "is current global actor" hook is not
available, assume that we are already executing on the right global
actor. This mimics the behavior of earlier standard libraries when
faced with an isolated conformance, as well as dealing with odd
configurations where the code might not load the concurrency library
yet

At the moment, WebAssembly ends up in this configuration because we
don't run the initialization for the concurrency library. That makes
this also a workaround for issue swiftlang#82682 / rdar://154762027.
@DougGregor DougGregor requested a review from a team as a code owner July 5, 2025 15:55
@DougGregor
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably good enough -- runtimes which are actually multithreaded would have the check/hook available AFAIK so this should be ok.

@DougGregor DougGregor merged commit b28a061 into swiftlang:release/6.2 Jul 7, 2025
5 checks passed
@DougGregor DougGregor deleted the isolated-conformance-without-concurrency-runtime-6.2 branch July 7, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants