fix: use 'toReadable' in 'pluralize' helper

swrlab · Apr 19, 2023 · 0eb7e9a · 0eb7e9a
1 parent 4ce19c9
commit 0eb7e9a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/tests/strings.js b/tests/strings.js
@@ -152,16 +152,16 @@ describe('Test Strings Package', () => {
 			expect(strings.pluralize(1, 'Apple')).to.equal('1 Apple')
 		})
 
-		it("pluralize(2, 'Apple') = '2 Apples'", () => {
-			expect(strings.pluralize(2, 'Apple')).to.equal('2 Apples')
+		it("pluralize(1000, 'Apple') = '1.000 Apples'", () => {
+			expect(strings.pluralize(1000, 'Apple')).to.equal('1.000 Apples')
 		})
 
 		it("pluralize(1, 'Child', 'Children') = '1 Child'", () => {
 			expect(strings.pluralize(1, 'Child', 'Children')).to.equal('1 Child')
 		})
 
-		it("pluralize(2, 'Child', 'Children') = '2 Children'", () => {
-			expect(strings.pluralize(2, 'Child', 'Children')).to.equal('2 Children')
+		it("pluralize(1000, 'Child', 'Children') = '1.000 Children'", () => {
+			expect(strings.pluralize(1000, 'Child', 'Children')).to.equal('1.000 Children')
 		})
 	})
 

diff --git a/utils/strings/pluralize.js b/utils/strings/pluralize.js
@@ -1,5 +1,7 @@
+const toReadable = require('../numbers/toReadable')
+
 // pluralize value to values or use custom plural
 module.exports = (count, singular, plural) => {
 	const multi = plural ?? `${singular}s`
-	return `${count} ${count !== 1 ? multi : singular}`
+	return `${toReadable(count)} ${count !== 1 ? multi : singular}`
 }