Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial states for phenotype control #36

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

smijeva
Copy link
Contributor

@smijeva smijeva commented Nov 27, 2024

No description provided.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (d52e970) to head (9988ac6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bindings/pbn_control/control.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   78.74%   78.75%   +0.01%     
==========================================
  Files          61       61              
  Lines       10322    10332      +10     
==========================================
+ Hits         8128     8137       +9     
- Misses       2194     2195       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smijeva smijeva requested a review from daemontus November 27, 2024 15:30
Copy link
Member

@daemontus daemontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed clap, otherwise LGTM. Maybe we can think about a reasonable corrctness test for this new parameter in the future...

@daemontus daemontus merged commit 8f6e646 into main Nov 28, 2024
26 checks passed
@daemontus daemontus deleted the feature/init_states_for_phen_control branch November 28, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants