Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturbation color cleanup #38

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

daemontus
Copy link
Member

@daemontus daemontus commented Nov 28, 2024

Add a method that will trim perturbation data from a ColorSet.

Also performs migration to the latest PyO3 version.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 72.88136% with 48 lines in your changes missing coverage. Please review.

Project coverage is 78.80%. Comparing base (8f6e646) to head (2257acb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/bindings/lib_param_bn/symbolic/model_color.rs 25.00% 18 Missing ⚠️
src/pyo3_utils.rs 33.33% 6 Missing ⚠️
...bindings/lib_param_bn/symbolic/symbolic_context.rs 75.00% 5 Missing ⚠️
src/bindings/pbn_control/set_perturbation.rs 33.33% 4 Missing ⚠️
src/bindings/lib_param_bn/model_annotation.rs 72.72% 3 Missing ⚠️
...indings/lib_param_bn/symbolic/set_colored_space.rs 50.00% 2 Missing ⚠️
src/bindings/lib_param_bn/symbolic/set_spaces.rs 50.00% 2 Missing ⚠️
src/bindings/lib_param_bn/symbolic/set_vertex.rs 50.00% 2 Missing ⚠️
...gs/lib_param_bn/symbolic/symbolic_space_context.rs 71.42% 2 Missing ⚠️
...c/bindings/pbn_control/set_colored_perturbation.rs 66.66% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   78.75%   78.80%   +0.05%     
==========================================
  Files          61       61              
  Lines       10332    10363      +31     
==========================================
+ Hits         8137     8167      +30     
- Misses       2195     2196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daemontus daemontus merged commit fd16dde into main Nov 28, 2024
25 of 26 checks passed
@daemontus daemontus deleted the frature/perturbation-color-cleanup branch November 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant