Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Show job data in descriptor edit form. #312

Merged

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Jun 10, 2020

Show job data in descriptor edit form

Add the option to show read only version of raw job data and raw messages in the job descriptor edit form. Option is disabled by default.

Problem

Job data is inaccessible in the jobs admin which makes debugging jobs quite difficult. It often requires the developer to download DB snapshot in order to do anything. In case job messages get corrupted (for example in case of getting truncated), they become inaccessible forcing the developer to rely on DB dump instead.

Solution

Expose job data and raw messages as read only fields in the job edit form.

Screen Shot 2020-06-11 at 9 17 55 AM

Screen Shot 2020-06-11 at 9 18 02 AM

Notes

Related issues

#313

@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/advanced-edit-from branch 2 times, most recently from 4025630 to 156fcf3 Compare June 10, 2020 21:26
@emteknetnz
Copy link
Collaborator

@mfendeksilverstripe this one will need to target 4 as it has new public functions / API

Code looks seems fine otherwise

Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine, you'll need to rebase/retarget this to 4 since it contains new API

@mfendeksilverstripe mfendeksilverstripe changed the base branch from 4.5 to 4 September 9, 2020 20:37
@mfendeksilverstripe
Copy link
Contributor Author

@emteknetnz Rebased to 4

@emteknetnz emteknetnz merged commit 1d65324 into symbiote:4 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants