Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW: Better Descriptor edit form UI. #314

Merged
merged 2 commits into from
Sep 1, 2020
Merged

NEW: Better Descriptor edit form UI. #314

merged 2 commits into from
Sep 1, 2020

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Jun 15, 2020 •
edited
Loading

Better Descriptor edit form UI

UI improvements for Queued Job Descriptor edit form.

Problem

  • Descriptor UI uses mostly scaffolded fields which very little description information
  • using individual fields for the intended purpose is really difficult and confusing
  • editing data through this form often requires extensive reading of documentation and source code

Solution

  • more descriptive UI with better naming convention
  • additional context information where needed

Related issues

#260

Preview

main

advanced

@mfendeksilverstripe mfendeksilverstripe mentioned this pull request Jun 15, 2020
Open
@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/job-edit-form-ui-improvement branch from 26bf112 to 86f79c7 Compare June 15, 2020 01:55
@mfendeksilverstripe mfendeksilverstripe force-pushed the feature/job-edit-form-ui-improvement branch from 8b6754e to 67a97d7 Compare June 15, 2020 02:32
emteknetnz
emteknetnz requested changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some minor text changes

src/DataObjects/QueuedJobDescriptor.php Outdated Show resolved Hide resolved
src/DataObjects/QueuedJobDescriptor.php Outdated Show resolved Hide resolved
src/DataObjects/QueuedJobDescriptor.php Outdated Show resolved Hide resolved
src/DataObjects/QueuedJobDescriptor.php Outdated Show resolved Hide resolved
@mfendeksilverstripe
Copy link
Contributor Author

@emteknetnz Thanks for great suggestions, updated the PR, please review.

@emteknetnz emteknetnz merged commit bbc147e into symbiote:4 Sep 1, 2020
@emteknetnz emteknetnz mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfendeksilverstripe @emteknetnz