[Validator] Update Expression constraint with "negate" option #16852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
Validator
Waiting Code Merge
carsonbot
changed the title
OskarStark
reviewed
Jun 6, 2022
fmata
force-pushed
the
constraint-expression
branch
from
51a7463 to
a8909ec
Compare
fmata
changed the title
fabpot
requested changes
Jul 21, 2022
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 21, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Add "negate" option to Expression constraint | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#16852 Using `Expression` constraint is tedious because the written expression is the opposite of the error message. Adding `negate` option (naming ?) as `Regex::$match` allow us to write condition in phase with the wording. Commits ------- 4bc245e Add "pass" option to Expression constraint
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Jul 21, 2022
This PR was merged into the 6.2 branch. Discussion ---------- Add "negate" option to Expression constraint | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#16852 Using `Expression` constraint is tedious because the written expression is the opposite of the error message. Adding `negate` option (naming ?) as `Regex::$match` allow us to write condition in phase with the wording. Commits ------- 4bc245e5a9 Add "pass" option to Expression constraint
OskarStark
reviewed
Jul 22, 2022
fmata
force-pushed
the
constraint-expression
branch
from
a8909ec to
0f2f72e
Compare
|
Comments addressed. |
fmata
force-pushed
the
constraint-expression
branch
from
0f2f72e to
0ca9832
Compare
OskarStark
approved these changes
Jul 22, 2022
|
Thanks for your work on this new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#46599