Skip to content

Document catch_all_throwables config #16918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 25, 2022

I didn't find any place where we discuss what exceptions is being caught by HttpKernel.

@carsonbot carsonbot added this to the 6.2 milestone Jun 25, 2022
Symfony 7.0 will catch all Throwables by default. Use ``framework.catch_all_throwables``
to opt-in to this behaviour now.

Make `:class:`Symfony\\Component\\HttpKernel\\HttpKernel`` catch every kind of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticks arrangement looks wrong, but I am currently on a phone 📱


.. versionadded:: 6.2

Symfony 7.0 will catch all Throwables by default. Use ``framework.catch_all_throwables``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .... option was introduced in Symfony 6.2.

The info for a new default value should not be part of the versionadded directive imho

Any idea @javiereguiluz

Maybe adding an additional versionchanged directive containing this info?

@Nyholm
Copy link
Member Author

Nyholm commented Jul 19, 2022

Closing this in favor of #17001

@Nyholm Nyholm closed this Jul 19, 2022
@Nyholm Nyholm deleted the issue-16917-thorwables branch July 19, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants