Skip to content

Add example about FlashBagAwareSessionInterface #16936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

VincentLanglet
Copy link
Contributor

This seems enough to close #16934 to me

@carsonbot carsonbot added this to the 6.2 milestone Jul 3, 2022
@OskarStark OskarStark changed the title Add example about FlashBagAwareSessionInterface Add example about FlashBagAwareSessionInterface Jul 4, 2022
@javiereguiluz
Copy link
Member

@VincentLanglet thanks for this contribution. However, after talking internally about this with the Symfony Core Team, I've decided to close this without merging it.

I've been told that the problem was that SessionInterface didn't have the methods that the Session class has to deal with flash messages. This is not important for most people because Session is the only implementation of SessionInterface. But for folks creating their own session implementations, it might be important.

So, your code changes are perfect and will help e.g. to fix "errors" reported by PHPStan ... but in practice, this is not really needed by most Symfony users. That's why I think it's better to not display these details in the docs. Thanks for understanding 🙏

@VincentLanglet
Copy link
Contributor Author

No problem !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants