Add entryExists
to EntrypointLookupInterface
#167
+4
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why it was proposed in #147 not to include
entryExists
inEntrypointLookupInterface
, but it doesn't makes sense to test agains't a specific class instead of the interface.In my case, this cause an issue as I cannot use dependence injection on
EntrypointLookupInterface
and expectentryExists
to be present.If this is not approved, I suggest adding
entryExists
to it's own interface and haveEntrypointLookup
implement both (although you won't fix the dependency injection problem).