-
Notifications
You must be signed in to change notification settings - Fork 536
Trash can versioning option for deletes only #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tejas-rkd
wants to merge
1
commit into
syncthing:main
Choose a base branch
from
tejas-rkd:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(#6164): add 'Archive Deleted Only' option to trashcan versioner
rasa
reviewed
May 16, 2025
@@ -37,6 +37,12 @@ days. If this is set to a positive number of days, files will be removed when | |||
they have been in the trash can that long. Setting this to zero prevents any | |||
files from being removed from the trash can automatically. | |||
|
|||
Another :opt:`configuration option <option:: folder.versioning.params.archiveDeletedOnly>` | |||
is available to archive only the deleted files, as opposed to normal Trash can versioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
is available to archive only the deleted files, as opposed to normal Trash can versioning | |
is available to archive only the deleted files, as opposed to normal trash can versioning |
rasa
reviewed
May 16, 2025
@@ -37,6 +37,12 @@ days. If this is set to a positive number of days, files will be removed when | |||
they have been in the trash can that long. Setting this to zero prevents any | |||
files from being removed from the trash can automatically. | |||
|
|||
Another :opt:`configuration option <option:: folder.versioning.params.archiveDeletedOnly>` | |||
is available to archive only the deleted files, as opposed to normal Trash can versioning | |||
which archives all modified, renamed and deleted file. This is a light weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
which archives all modified, renamed and deleted file. This is a light weight | |
which archives all modified, renamed and deleted files. This is a lightweight |
rasa
reviewed
May 16, 2025
.. option:: folder.versioning.params.archiveDeletedOnly | ||
|
||
When this option is enabled it archives only deleted files. | ||
Modified or Renamed files are not archieved and hence, deleted permanently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Modified or Renamed files are not archieved and hence, deleted permanently. | |
Modified or renamed files are not archived, and hence, deleted normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(#6164): add 'Archive Deleted Only' option to trashcan versioner